UI: Hand Cursors #127164

Merged
Harley Acheson merged 4 commits from Harley/blender:HandCursors into main 2024-09-06 19:06:20 +02:00
Member

We are currently a bit confused regarding "hand" and "move" cursors. We
have a single define for WM_CURSOR_HAND which maps to a single ghost
cursor called GHOST_kStandardCursorMove. It is not correct to use a
"hand" to indicate move on Windows, and Mac needs a closed hand and a
pointing hand. This PR makes it so that WM_CURSOR_MOVE uses
GHOST_kStandardCursorMove, WM_CURSOR_HAND uses
GHOST_kStandardCursorHandOpen, WM_CURSOR_HAND_CLOSED uses
GHOST_kStandardCursorHandClosed, and WM_CURSOR_HAND_POINT uses
GHOST_kStandardCursorHandPoint. Although we don't use hand cursors on
Windows this adds cur files for these for completeness and testing.


On Mac this PR will just use the standard OS-supplied hand cursors for WM_CURSOR_HAND_POINT, WM_CURSOR_HAND, and WM_CURSOR_HAND_CLOSED. WM_CURSOR_MOVE will be the same cursor as WM_CURSOR_HAND (open hand).

image

On Windows WM_CURSOR_MOVE will use the standard "move" cursor that looks like this:

image

And WM_CURSOR_HAND, WM_CURSOR_HAND_POINT, and WM_CURSOR_HAND_CLOSED will show custom cursors taken from this GPL-3.0 licensed project: https://github.com/ful1e5/apple_cursor

image

We are currently a bit confused regarding "hand" and "move" cursors. We have a single define for WM_CURSOR_HAND which maps to a single ghost cursor called GHOST_kStandardCursorMove. It is not correct to use a "hand" to indicate move on Windows, and Mac needs a closed hand and a pointing hand. This PR makes it so that WM_CURSOR_MOVE uses GHOST_kStandardCursorMove, WM_CURSOR_HAND uses GHOST_kStandardCursorHandOpen, WM_CURSOR_HAND_CLOSED uses GHOST_kStandardCursorHandClosed, and WM_CURSOR_HAND_POINT uses GHOST_kStandardCursorHandPoint. Although we don't use hand cursors on Windows this adds cur files for these for completeness and testing. --- On Mac this PR will just use the standard OS-supplied hand cursors for WM_CURSOR_HAND_POINT, WM_CURSOR_HAND, and WM_CURSOR_HAND_CLOSED. WM_CURSOR_MOVE will be the same cursor as WM_CURSOR_HAND (open hand). ![image](/attachments/e124c383-3b56-4558-bcda-5f3bf499074f) On Windows WM_CURSOR_MOVE will use the standard "move" cursor that looks like this: ![image](/attachments/29b4d0f2-7edf-4c0f-8021-0bc4c8d1934d) And WM_CURSOR_HAND, WM_CURSOR_HAND_POINT, and WM_CURSOR_HAND_CLOSED will show custom cursors taken from this GPL-3.0 licensed project: https://github.com/ful1e5/apple_cursor ![image](/attachments/c4b9519f-6155-4424-91c8-4f0cb76586ef)
Harley Acheson added 1 commit 2024-09-05 01:17:14 +02:00
UI: Hand Cursors
Some checks failed
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
5b2bf4d8f8
We are currently a bit confused regarding "hand" and "move" cursors. We
have a single define for WM_CURSOR_HAND which maps to a single ghost
cursor called GHOST_kStandardCursorMove. It is not correct to use a
"hand" to indicate move on Windows, and Mac needs a closed hand and a
pointing hand. This PR makes it so that WM_CURSOR_MOVE uses
GHOST_kStandardCursorMove, WM_CURSOR_HAND uses
GHOST_kStandardCursorHandOpen, WM_CURSOR_HAND_CLOSED uses
GHOST_kStandardCursorHandClosed, and WM_CURSOR_HAND_POINT uses
GHOST_kStandardCursorHandPoint. Although we don't use hand cursors on
Windows this adds cur files for these for completeness and testing.
Harley Acheson requested review from Pablo Vazquez 2024-09-05 01:30:45 +02:00
Harley Acheson added this to the Module: User Interface project 2024-09-05 01:30:53 +02:00
Member

Awesome!

Tried WM_CURSOR_HAND_CLOSED for docking areas and it is much nicer than the regular arrow cursor:

Awesome! Tried `WM_CURSOR_HAND_CLOSED` for docking areas and it is much nicer than the regular arrow cursor: <video src="/attachments/f25b2143-8a85-48ca-840a-fbd16fcdc60a" title="closedhand.mov" controls></video>
Pablo Vazquez approved these changes 2024-09-05 11:24:41 +02:00
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson added 2 commits 2024-09-06 04:12:52 +02:00
For wayland just use move cursor
All checks were successful
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.
04642de34c
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson added 1 commit 2024-09-06 19:02:58 +02:00
Harley Acheson merged commit 458c60269b into main 2024-09-06 19:06:20 +02:00
Harley Acheson referenced this issue from a commit 2024-09-06 19:06:20 +02:00
Harley Acheson deleted branch HandCursors 2024-09-06 19:06:23 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest
glTF
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#127164
No description provided.